Skip to content

Commit

Permalink
bug #20991 [cache] Bump RedisAdapter default timeout to 5s (Nicofuma)
Browse files Browse the repository at this point in the history
This PR was merged into the 3.1 branch.

Discussion
----------

[cache] Bump RedisAdapter default timeout to 5s

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Bump RedisAdapter timeout to 5s because (at least with Predis) 0 means 0s

Commits
-------

eaca2a4 [cache] Bump RedisAdapter timeout to 5s
  • Loading branch information
nicolas-grekas committed Dec 27, 2016
2 parents 4c453f6 + eaca2a4 commit d283842
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Symfony/Component/Cache/Adapter/RedisAdapter.php
Expand Up @@ -25,8 +25,8 @@ class RedisAdapter extends AbstractAdapter
private static $defaultConnectionOptions = array(
'class' => null,
'persistent' => 0,
'timeout' => 0,
'read_timeout' => 0,
'timeout' => 30,

This comment has been minimized.

Copy link
@Koc

Koc Jan 2, 2017

Contributor

It looks like 30 seconds, not 5

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jan 2, 2017

Author Member

I changed to 30s while merging, but forgot to amen the commit message...

'read_timeout' => 30,
'retry_interval' => 0,
);
private $redis;
Expand Down

0 comments on commit d283842

Please sign in to comment.