Skip to content

Commit

Permalink
minor #28880 [HttpFoundation] Publicify new consts (ro0NL)
Browse files Browse the repository at this point in the history
This PR was merged into the 4.2-dev branch.

Discussion
----------

[HttpFoundation] Publicify new consts

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Continuation of #28807

I think it's reasonable to enforce visibility for new consts, ideally solved by PHP-CS-Fixer. This makes it explicit for the consts to be consumed as part of public API.

Commits
-------

ce95d0d [HttpFoundation] Publicify new consts
  • Loading branch information
fabpot committed Oct 15, 2018
2 parents 76f80e9 + ce95d0d commit d813148
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Symfony/Component/HttpFoundation/HeaderUtils.php
Expand Up @@ -18,8 +18,8 @@
*/
class HeaderUtils
{
const DISPOSITION_ATTACHMENT = 'attachment';
const DISPOSITION_INLINE = 'inline';
public const DISPOSITION_ATTACHMENT = 'attachment';
public const DISPOSITION_INLINE = 'inline';

/**
* This class should not be instantiated.
Expand Down

0 comments on commit d813148

Please sign in to comment.