[Process] changed ExecutableFinder to return false instead of throwin…

…g an exception when the executable is not found

I've made the change as the executable goal is to find the executable. The fact that it does not find it is
part of the contract and it is not exceptional.

src/Symfony/Bundle/AsseticBundle/DependencyInjection/Configuration.php

@@ -12,7 +12,6 @@
 namespace Symfony\Bundle\AsseticBundle\DependencyInjection;
 
 use Symfony\Component\Process\ExecutableFinder;
-use Symfony\Component\Process\Exception\ExecutableNotFoundException;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 
@@ -58,9 +57,9 @@ public function getConfigTreeBuilder()
                 ->booleanNode('use_controller')->defaultValue($this->debug)->end()
                 ->scalarNode('read_from')->defaultValue('%kernel.root_dir%/../web')->end()
                 ->scalarNode('write_to')->defaultValue('%assetic.read_from%')->end()
-                ->scalarNode('java')->defaultValue(function() use ($finder) { try { return $finder->find('java'); } catch(ExecutableNotFoundException $ex) { return null; } })->end()
-                ->scalarNode('node')->defaultValue(function() use ($finder) { try { return $finder->find('node'); } catch(ExecutableNotFoundException $ex) { return null; } })->end()
-                ->scalarNode('sass')->defaultValue(function() use ($finder) { try { return $finder->find('sass'); } catch(ExecutableNotFoundException $ex) { return null; } })->end()
+                ->scalarNode('java')->defaultValue(function() use ($finder) { $java = $finder->find('java'); return $java ? $java : '/usr/bin/java'; })->end()
+                ->scalarNode('node')->defaultValue(function() use ($finder) { $node = $finder->find('node'); return $node ? $node : '/usr/bin/node'; })->end()
+                ->scalarNode('sass')->defaultValue(function() use ($finder) { $saas = $finder->find('saas'); return $saas ? $saas : '/usr/bin/saas'; })->end()
             ->end()
 
             // bundles

src/Symfony/Component/Process/ExecutableFinder.php

@@ -11,8 +11,6 @@
 
 namespace Symfony\Component\Process;
 
-use Symfony\Component\Process\Exception\ExecutableNotFoundException;
-
 /**
  * Generic executable finder.
  *
@@ -33,6 +31,13 @@ public function addSuffix($suffix)
         $this->suffixes[] = $suffix;
     }
 
+    /**
+     * Finds an executable by name.
+     *
+     * @param string $name The executable name (without the extension)
+     *
+     * @return string|false The executable path or false if it cannot be found
+     */
     public function find($name)
     {
         $dirs = explode(PATH_SEPARATOR, getenv('PATH') ? getenv('PATH') : getenv('Path'));
@@ -45,6 +50,6 @@ public function find($name)
             }
         }
 
-        throw new ExecutableNotFoundException($name);
+        return false;
     }
-}
+}

src/Symfony/Component/Process/PhpExecutableFinder.php

@@ -28,11 +28,16 @@ public function __construct()
         $this->executableFinder = new ExecutableFinder();
     }
 
+    /**
+     * Finds The PHP executable.
+     *
+     * @return string|false The PHP executable path or false if it cannot be found
+     */
     public function find()
     {
         if ($php = getenv('PHP_PATH')) {
             if (!is_executable($php)) {
-                throw new RuntimeException('The defined PHP_PATH environment variable is not a valid PHP executable.');
+                return false;
             }
 
             return $php;
@@ -53,4 +58,4 @@ public function find()
 
         return $this->executableFinder->find('php');
     }
-}
+}

src/Symfony/Component/Process/PhpProcess.php

@@ -67,7 +67,10 @@ public function setPhpBinary($php)
     public function run($callback = null)
     {
         if (null === $this->getCommandLine()) {
-            $this->setCommandLine($this->executableFinder->find());
+            if (false === $php = $this->executableFinder->find()) {
+                throw new \RuntimeException('Unable to find the PHP executable.');
+            }
+            $this->setCommandLine($php);
         }
 
         return parent::run($callback);