Skip to content

Commit

Permalink
bug #30498 [translation] Update defaut format from yml to yaml (GaryP…
Browse files Browse the repository at this point in the history
…EGEOT)

This PR was squashed before being merged into the 3.4 branch (closes #30498).

Discussion
----------

[translation] Update defaut format from yml to yaml

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30443
| License       | MIT
| Doc PR        |

As stated in #30443 , command `php bin/console translation:update --dump-messages --force fr` will by default output the translation to yml format, which is not supported by Symfony

Commits
-------

ba42030 [translation] Update defaut format from yml to yaml
  • Loading branch information
fabpot committed Mar 9, 2019
2 parents 7d227e9 + ba42030 commit ee62741
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Expand Up @@ -83,7 +83,7 @@ protected function configure()
new InputArgument('bundle', InputArgument::OPTIONAL, 'The bundle name or directory where to load the messages'),
new InputOption('prefix', null, InputOption::VALUE_OPTIONAL, 'Override the default prefix', '__'),
new InputOption('no-prefix', null, InputOption::VALUE_NONE, '[DEPRECATED] If set, no prefix is added to the translations'),
new InputOption('output-format', null, InputOption::VALUE_OPTIONAL, 'Override the default output format', 'yml'),
new InputOption('output-format', null, InputOption::VALUE_OPTIONAL, 'Override the default output format', 'yaml'),
new InputOption('dump-messages', null, InputOption::VALUE_NONE, 'Should the messages be dumped in the console'),
new InputOption('force', null, InputOption::VALUE_NONE, 'Should the update be done'),
new InputOption('no-backup', null, InputOption::VALUE_NONE, 'Should backup be disabled'),
Expand Down
Expand Up @@ -143,7 +143,7 @@ private function createCommandTester($extractedMessages = [], $loadedMessages =
->expects($this->any())
->method('getFormats')
->will(
$this->returnValue(['xlf', 'yml'])
$this->returnValue(['xlf', 'yml', 'yaml'])
);

if (null === $kernel) {
Expand Down

0 comments on commit ee62741

Please sign in to comment.