bug #22343 [Dotenv] Throwing an exception when loading a directory (s…

…anpii) This PR was merged into the 3.3-dev branch. Discussion ---------- [Dotenv] Throwing an exception when loading a directory | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 8b83b58 Throwing an exception when loading a directory
symfony · Apr 10, 2017 · f7debe8 · f7debe8
2 parents eeb36eb + 8b83b58
commit f7debe8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Symfony/Component/Dotenv/Dotenv.php b/src/Symfony/Component/Dotenv/Dotenv.php
@@ -48,7 +48,7 @@ public function load(/*...$paths*/)
     {
         // func_get_args() to be replaced by a variadic argument for Symfony 4.0
         foreach (func_get_args() as $path) {
-            if (!is_readable($path)) {
+            if (!is_readable($path) || is_dir($path)) {
                 throw new PathException($path);
             }
 

diff --git a/src/Symfony/Component/Dotenv/Tests/DotenvTest.php b/src/Symfony/Component/Dotenv/Tests/DotenvTest.php
@@ -145,4 +145,13 @@ public function getEnvData()
 
         return $tests;
     }
+
+    /**
+     * @expectedException \Symfony\Component\Dotenv\Exception\PathException
+     */
+    public function testLoadDirectory()
+    {
+        $dotenv = new Dotenv();
+        $dotenv->load(__DIR__);
+    }
 }