Skip to content

Commit

Permalink
minor #20002 [HttpFoundation] Enable memcached tests with the latest …
Browse files Browse the repository at this point in the history
…memcached extension (jakzal)

This PR was merged into the 2.7 branch.

Discussion
----------

[HttpFoundation] Enable memcached tests with the latest memcached extension

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

The check was introduced because of #9797. The issue is now fixed in the memcached extension, but only for the upcoming 3.0 release (for PHP7).

I've tested it with the latest memcached extension built from source and PHP 7.0.8.

Commits
-------

b482fb7 [HttpFoundation] Enable memcached tests with the latest memcached extension
  • Loading branch information
fabpot committed Sep 21, 2016
2 parents ca0fdf8 + b482fb7 commit f7fc01d
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -37,8 +37,8 @@ protected function setUp()

parent::setUp();

if (version_compare(phpversion('memcached'), '2.2.0', '>=')) {
$this->markTestSkipped('Tests can only be run with memcached extension 2.1.0 or lower');
if (version_compare(phpversion('memcached'), '2.2.0', '>=') && version_compare(phpversion('memcached'), '3.0.0b1', '<')) {
$this->markTestSkipped('Tests can only be run with memcached extension 2.1.0 or lower, or 3.0.0b1 or higher');
}

$this->memcached = $this->getMock('Memcached');
Expand Down

0 comments on commit f7fc01d

Please sign in to comment.