[Form] Added hook method preprocessData() to FieldGroup

symfony · Nov 23, 2010 · f9e830c · f9e830c
1 parent 4aa1224
commit f9e830c
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 5 deletions.
diff --git a/src/Symfony/Component/Form/FieldGroup.php b/src/Symfony/Component/Form/FieldGroup.php
@@ -332,6 +332,8 @@ public function bind($taintedData)
             }
         }
 
+        $taintedData = $this->preprocessData($taintedData);
+
         foreach ($taintedData as $key => $value) {
             if ($this->has($key)) {
                 $this->fields[$key]->bind($value);
@@ -358,6 +360,19 @@ public function bind($taintedData)
         }
     }
 
+    /**
+     * Processes the bound data before it is passed to the individual fields
+     *
+     * The data is in the user format.
+     *
+     * @param  array $data
+     * @return array
+     */
+    protected function preprocessData(array $data)
+    {
+        return $data;
+    }
+
     /**
      * Returns whether this form was bound with extra fields
      *

diff --git a/tests/Symfony/Tests/Component/Form/FieldGroupTest.php b/tests/Symfony/Tests/Component/Form/FieldGroupTest.php
@@ -130,16 +130,28 @@ public function testHasNoErrorsIfOnlyFieldHasErrors()
         $this->assertFalse($group->hasErrors());
     }
 
-    public function testBindForwardsBoundValues()
+    public function testBindForwardsPreprocessedData()
     {
         $field = $this->createMockField('firstName');
-        $field->expects($this->once())
-                    ->method('bind')
-                    ->with($this->equalTo('Bernhard'));
 
-        $group = new TestFieldGroup('author');
+        $group = $this->getMock(
+            'Symfony\Tests\Component\Form\Fixtures\TestFieldGroup',
+            array('preprocessData'), // only mock preprocessData()
+            array('author')
+        );
+
+        // The data array is prepared directly after binding
+        $group->expects($this->once())
+              ->method('preprocessData')
+              ->with($this->equalTo(array('firstName' => 'Bernhard')))
+              ->will($this->returnValue(array('firstName' => 'preprocessed[Bernhard]')));
         $group->add($field);
 
+        // The preprocessed data is then forwarded to the fields
+        $field->expects($this->once())
+                    ->method('bind')
+                    ->with($this->equalTo('preprocessed[Bernhard]'));
+
         $group->bind(array('firstName' => 'Bernhard'));
     }