[Command] Fix array option parsing

symfony · Jun 7, 2011 · fb051b2 · fb051b2
1 parent 6737bd3
commit fb051b2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/Symfony/Component/Console/Input/ArgvInput.php b/src/Symfony/Component/Console/Input/ArgvInput.php
@@ -229,7 +229,13 @@ private function addLongOption($name, $value)
             $value = $option->isValueOptional() ? $option->getDefault() : true;
         }
 
-        $this->options[$name] = $value;
+        if ($option->isArray() && isset($this->options[$name])) {
+            $this->options[$name][] = $value;
+        } else if ($option->isArray()) {
+            $this->options[$name] = array($value);
+        } else {
+            $this->options[$name] = $value;
+        }
     }
 
     /**

diff --git a/tests/Symfony/Tests/Component/Console/Input/ArgvInputTest.php b/tests/Symfony/Tests/Component/Console/Input/ArgvInputTest.php
@@ -147,6 +147,10 @@ public function testParser()
         } catch (\RuntimeException $e) {
             $this->assertNotEquals('Too many arguments.', $e->getMessage(), '->parse() parses array arguments');
         }
+
+        $input = new ArgvInput(array('cli.php', '--name=foo', '--name=bar', '--name=baz'));
+        $input->bind(new InputDefinition(array(new InputOption('name', null, InputOption::VALUE_OPTIONAL | InputOption::VALUE_IS_ARRAY))));
+        $this->assertEquals(array('name' => array('foo', 'bar', 'baz')), $input->getOptions());
     }
 
     public function testGetFirstArgument()