[Routing] fixed URL generation when an optional variable value is 0

symfony · Apr 26, 2011 · fefee0d · fefee0d
1 parent 035afc1
commit fefee0d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Symfony/Component/Routing/Generator/UrlGenerator.php b/src/Symfony/Component/Routing/Generator/UrlGenerator.php
@@ -110,7 +110,7 @@ protected function doGenerate($variables, $defaults, $requirements, $tokens, $pa
                         throw new \InvalidArgumentException(sprintf('Parameter "%s" for route "%s" must match "%s" ("%s" given).', $token[3], $name, $token[2], $tparams[$token[3]]));
                     }
 
-                    if ($tparams[$token[3]] || !$optional) {
+                    if (!in_array($tparams[$token[3]], array(null, '', false), true) || !$optional) {
                         // %2F is not valid in a URL, so we don't encode it (which is fine as the requirements explicitly allowed it)
                         $url = $token[1].str_replace('%2F', '/', urlencode($tparams[$token[3]])).$url;
                     }

diff --git a/tests/Symfony/Tests/Component/Routing/Generator/UrlGeneratorTest.php b/tests/Symfony/Tests/Component/Routing/Generator/UrlGeneratorTest.php
@@ -82,6 +82,14 @@ public function testRelativeUrlWithNullParameterButNotOptional()
         $this->assertEquals('/app.php/testing//bar', $url);
     }
 
+    public function testRelativeUrlWithOptionalZeroParameter()
+    {
+        $routes = $this->getRoutes('test', new Route('/testing/{page}'));
+        $url = $this->getGenerator($routes)->generate('test', array('page' => 0), false);
+
+        $this->assertEquals('/app.php/testing/0', $url);
+    }
+
     public function testRelativeUrlWithExtraParameters()
     {
         $routes = $this->getRoutes('test', new Route('/testing'));