Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
minor #35178 [PhpUnitBridge][SymfonyTestsListenerTrait] Remove some u…
…nneeded code (fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge][SymfonyTestsListenerTrait] Remove some unneeded code | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Risky errors when there are no assertions are added before the test end listeners are called (ie, before the code in endTest is executed) so forcing beStrictAboutTestsThatDoNotTestAnything to false when there is a expectedDeprecation annotation is enough. If the goal is to reset the value to the original value, then I think we should not do it since we basically "lie" to the next listeners. Let's assume that when a test expect a deprecation, it can have 0 assertions. Also this flag is not used anymore by PHPUnit after we reset it. Ref #21786 btw Commits ------- fb48bbc [PhpUnitBridge][SymfonyTestsListenerTrait] Remove some unneeded code
- Loading branch information