[Security] SwitchUser is broken when the User Provider always returns a valid user #34551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urns a valid user
chalasr
approved these changes
Nov 23, 2019
nicolas-grekas
approved these changes
Nov 23, 2019
fabpot
approved these changes
Nov 24, 2019
|
Thank you @tucksaun. |
fabpot
added a commit
that referenced
this pull request
Nov 24, 2019
…ays returns a valid user (tucksaun) This PR was merged into the 4.3 branch. Discussion ---------- [Security] SwitchUser is broken when the User Provider always returns a valid user | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a Since bcfc282, if a UserProvider always returns a valid User object (which can happen in some OAuth workflow), switching user is not possible anymore as we hit the `LogicException`. This patch should be safe as the timing-attack prevention is kept. Commits ------- 2bf6cd2 [Security] Fix SwitchUser is broken when the User Provider always returns a valid user
This was referenced Dec 1, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since bcfc282, if a UserProvider always returns a valid User object (which can happen in some OAuth workflow), switching user is not possible anymore as we hit the
LogicException.This patch should be safe as the timing-attack prevention is kept.