Skip to content
This repository has been archived by the owner on Mar 30, 2020. It is now read-only.

Sample NLP Rule #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sample NLP Rule #7

wants to merge 3 commits into from

Conversation

LRParser
Copy link

Adding a sample NLP rule. Should have a link in documentation to the related NLP server, at: github.com/LRParser/nlp-server

Please let me know what you think!

@maoo
Copy link
Contributor

maoo commented Jun 27, 2017

Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have you on file. In order for us to review and merge your code, please follow the link above and follow the instructions. If you have questions or believe you've received this message in error, don't hesitate to contact Aaron Williamson, our General Counsel and Director of Governance.

CLA has not been signed by users @LRParser

@maoo
Copy link
Contributor

maoo commented Jun 27, 2017

Thanks @LRParser , your PR looks very interesting! I'll give it a try next week; meanwhile @jonfreedman @mistryvinay , feel free to checkout and comment!

@LRParser
Copy link
Author

LRParser commented Jul 4, 2017

Will work on agreement this week

@LRParser
Copy link
Author

LRParser commented Jul 4, 2017

@maoo I don't see any link above -
Can you please add it here?

@maoo
Copy link
Contributor

maoo commented Jul 4, 2017

@LRParser
Copy link
Author

Thanks, agreement sent to secretary@symphony.foundation

@copiesofcopies
Copy link

copiesofcopies commented Jul 10, 2017

Thanks, @LRParser! We've received your agreement. You're good to go. (💯 domain, by the way)

@maoo
Copy link
Contributor

maoo commented Jul 17, 2017

@LRParser , I finally got the time to review and test this PR.

The idea is definitely interesting and I think it would be a good contribution to bot-butler, as a demo to build chat bots that rely on an additional server component, like the nlp-server you built.

Before merging this PR, I'd propose the following additions:

  1. Only 'hear' messages with a given prefix (see https://github.com/LRParser/bot-butler/blob/master/src/scripts/nlp.coffee#L21); if not, all commands sent to the butler (regardless their feature) would be parsed; I think that for demo purposes it's better to use a prefix, even though the final purpose of this script is to intercept all messages
  2. Add script documentation (see example), to provide guidelines via the command butler help
  3. Add documentation to bot-butler with step-by-step instructions on how to run an nlp-server locally; I've tried and stumbled on an issue
  4. Add documentation on how to interact with the NLP script, what it does and what is the added value

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants