New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't change the case of autolev variables #15166
Comments
@moorepants Many Autolev examples I came across were in all caps so I thought it wouldn't look good in Python. I agree with this though. Adding an option would be the best way to go. |
Ok, so maybe something like:
Gonna add "easy to fix" on this one. Might be good PR for a newcomer. |
@moorepants I'd like to add this functionality, I am not very thorough with the code base yet so could you guide me with what auto lev parser is or if you tell me where the files for it is , I check physics/mechanics didn't find it any where. |
The files are in |
Alright, can i work on this issue ? @moorepants |
You don't need to ask if you can work on the issue. Just say you are and do it. |
@CodHeK
|
@NikhilPappu Alright I'll make the following changes. Is there any way I could test it ? |
@moorepants @CodHeK Now that I took a closer look at this, I feel it isn't that easy to fix for someone else. I think I shall fix it myself and maybe update it so that it is easier to make changes from now. |
@NikhilPappu The Changes to |
@CodHeK Technically yes but there is a lot more to it. For instance, you would need to use |
@NikhilPappu @moorepants I am working on this issue and want to completely understand this parser as I am willing to extend the parser for other languages as a project for GSOC'19. |
@NikhilPappu Can you tell me what exact values does the |
Hello, |
@moorepants Hello Jason, hopefully you are fine! |
Currently the autolev parser converts all autolev variables into lower case python equivalents. This introduces cognitive overload for the reader of the two code versions. Autolev is case insensitive but an author of the autolev code may (and is likely) to use case when writing the code to help with readability. When we convert everything to lower case it is hard to read both sets of code and check for errors etc. We should not change the case of the Autolev code (even though python style guides recommend lower case variables). This could be an option in the parser, but the default should be to not change case.
@NikhilPappu do you have thoughts on this?
The text was updated successfully, but these errors were encountered: