external/test_sage: Disable Sage tests under Python 3 #1000
Conversation
A recent commit allowed us to run Sage tests if Sage is installed (as they have to be ran from within Sage). However, Sage does not currently support Python 3, so disable the tests if running under Python 3.
|
Oh and wow, pull request 1000. :) We were in the 200s when I went my first pull last Spring... |
|
Nice! Pull request #1 was opened on August 31, 2010, just under a year and half ago. Perhaps it's prophetic that it's a pull request relating to Python 3 and Sage. |
|
Regarding the fix, I'm +1 if the bot tests pass (and if the sage tests are run correctly in Python 2). |
|
SymPy Bot Summary: There were test failures. @vperic: Please fix the test failures. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYxaAKDA Interpreter: /Library/Frameworks/Python.framework/Versions/3.2/bin/python3 (3.2.2-final-0) Automatic review by SymPy Bot. |
|
SymPy Bot Summary: All tests have passed. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY1eYKDA Interpreter: /usr/local/bin/python2.5 (2.5.0-final-0) Automatic review by SymPy Bot. |
|
Ok, I should've known this'd happen - the solution is to have the check in setup.py. I'll leave it in the original file too, though - someone might want to run the test outside of setup.py test and it's not good to confuse such users. |
|
SymPy Bot Summary: All tests have passed. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYiNcKDA Interpreter: /usr/local/bin/python2.5 (2.5.0-final-0) Automatic review by SymPy Bot. |
|
SymPy Bot Summary: There were test failures. @vperic: Please fix the test failures. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY5pgKDA Interpreter: /Library/Frameworks/Python.framework/Versions/3.2/bin/python3 (3.2.2-final-0) Automatic review by SymPy Bot. |
The previous commit doesn't cover all the cases - it is still possible to execute some Python 3 code under Python 2. Fix by explicitly checking the Python version in setup.py.
|
D'oh, I'm an idiot. Should be ok now. Serves me right for writing code when tired and not being able to test myself. |
|
SymPy Bot Summary: All tests have passed. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYitcKDA Interpreter: /Library/Frameworks/Python.framework/Versions/3.2/bin/python3 (3.2.2-final-0) Automatic review by SymPy Bot. |
|
@asmeurer, is anything blocking this? Seems to work fine. If no one comments by tomorrow, I'll merge (or you can marge earlier, of course). |
|
I guess it's fine. I can't run the Python 2 bot because of issue 3036, but I think everything passes there. |
|
Ok, merging, thanks Aaron. |
external/test_sage: Disable Sage tests under Python 3
A recent commit allowed us to run Sage tests if Sage is installed (as
they have to be ran from within Sage). However, Sage does not currently
support Python 3, so disable the tests if running under Python 3.
I noticed this in this sympy-bot report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYw6AKDA
@asmeurer, can you test it please? I don't have Sage (and I'd rather not install it).