Remove the explicit ruby requirement in Gemfile. #99
Conversation
Shall we try letting go of Ruby 1.9? Ruby 2 works with Rails 3.2, for some time now, so it seems stable: rails/rails#9406 Motivation: It might be better to avoid forcing beginners -- coming to this beginner-friendly project -- to use the older Ruby version, from the get-go. In LocalSupport specifically, after removing this line from the Gemfile, the unit tests still all pass and clicking around a bit, the site renders well blackbox-wise as well.
|
I tend to err on the conservative side here. We want to be friendly to beginners, but we also have a real client and the number one priority is keep their side working. Their site runs on Heroku, and so we need proper Heroku deployment tests of any version changes before pulling things in. Have you tried deploying the system to your own heroku instance? Many others have: https://sites.google.com/site/saasellsprojects/projects/local-support/heroku-sites I can see you are only submitting minor changes at the moment, but do remote pair program on everything as much as possible. It's critical for spreading knowledge through the team. Any time you are thinking of working on Local Support do mention it in the skype channels, and if you know in advance you are going to have a chunk of time to work on things, please do post an event in the pair programming group: https://sites.google.com/site/saasellsprojects/remote-pair-programming/creating-a-pp-event-on-g |
|
Ok, you use heroku. I'll try it. |
|
cool - and if you're connected to the internet, why not try it while pairing with someone? https://sites.google.com/site/saasellsprojects/remote-pair-programming/creating-a-pp-event-on-g we've got you in the relevant Skype chat rooms right? I'm "tansaku" on skype ... |
|
So, just for the record, the specs and cukes pass, it spins up fine on heroku as well. However I can understand it being perhaps a bit precipitous right now to merge this in (which would then require, at minimum, people who hadn't already installed or configured for 2.0.0 locally, to now do so). So let's just nuke this. If nothing else we've demonstrated that we can move to Ruby 2.0.0 whenever we want to. That fact should help with an eventual Rails 4 move too. |
Shall we try letting go of Ruby 1.9? Ruby 2 works with Rails 3.2, for
some time now, so it seems stable:
rails/rails#9406
Motivation: It might be better to avoid forcing beginners -- coming to
this beginner-friendly project -- to use the older Ruby version, from
the get-go.
In LocalSupport specifically, after removing this line from the
Gemfile, the unit tests still all pass and clicking around a bit, the
site renders well blackbox-wise too.