Made new classes for updated geometry #2085
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AlexHls <AlexHls@users.noreply.github.com> Co-authored-by: Wolfgang Kerzendorf <wkerzendorf@users.noreply.github.com> Co-authored-by: Joshua Shields <jvshields@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-authored-by: AlexHls <AlexHls@users.noreply.github.com> Co-authored-by: Joshua Shields <jvshields@users.noreply.github.com>
|
Removed calculate_distance_new from PR |
wkerzendorf
reviewed
Jul 7, 2022
|
|
||
| if shortest == (inner_1 or inner_2): | ||
| if (shortest == inner_1) or (shortest == inner_2): |
wkerzendorf
reviewed
Jul 7, 2022
| from tardis.energy_input.util import H_CGS_KEV | ||
|
|
||
|
|
||
| @pytest.fixture(scope="function") |
There was a problem hiding this comment.
remove as not relevant to PR.
Codecov Report
@@ Coverage Diff @@
## master #2085 +/- ##
==========================================
+ Coverage 58.04% 58.13% +0.08%
==========================================
Files 76 75 -1
Lines 8743 8623 -120
==========================================
- Hits 5075 5013 -62
+ Misses 3668 3610 -58
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
andrewfullard
approved these changes
Jul 22, 2022
andrewfullard
approved these changes
Jul 22, 2022
|
wait with merge until @code-explorer is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Sona Chitchyan chitchyan.sona@gmail.com
Co-authored-by: AlexHls AlexHls@users.noreply.github.com
Co-authored-by: Wolfgang Kerzendorf wkerzendorf@users.noreply.github.com
Co-authored-by: Joshua Shields jvshields@users.noreply.github.com
📝 Description
Type: 🎢
infrastructureIn numba_interface.py, wrote new classes GeometryGridSpherical1D, GeometryGridCartesian2D, and GeometryGridCartesian3D and appropriate numba_spec files. These will be used by TARDIS as different geometries for different explosions. We also made
calculate_distance_new.py, and copied the 1D spherical distance calculation into it. We will put all future distance calculations in it. Made a fix to a conditional in gamma_ray_grid.py
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel