Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLTE excitation solver #2405

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sonachitchyan
Copy link
Member

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

This PR implements NLTE excitation solver

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #2405 (403e4b2) into master (a3bb122) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

❗ Current head 403e4b2 differs from pull request most recent head 8cc0444. Consider uploading reports for the commit 8cc0444 to get more accurate results

@@            Coverage Diff             @@
##           master    #2405      +/-   ##
==========================================
- Coverage   68.49%   68.31%   -0.19%     
==========================================
  Files         145      146       +1     
  Lines       13247    13282      +35     
==========================================
  Hits         9073     9073              
- Misses       4174     4209      +35     
Files Changed Coverage Δ
tardis/plasma/properties/nlte_excitation_matrix.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant