NumberDensity as Input to plasma #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return elemental_number_density | ||
|
|
||
| @property | ||
| def isotopic_number_density(self): |
There was a problem hiding this comment.
I believe the composition.isotopic_number_density produces the correct values because it uses isotope masses rather than the effective element masses, so it should be possible to use that instead.
andrewfullard
previously approved these changes
May 13, 2024
wkerzendorf
force-pushed
the
restructure/plasma_prepare
branch
2 times, most recently
from
6b53bd0
to
18cff3c
Compare
wkerzendorf
force-pushed
the
restructure/plasma_prepare
branch
from
18cff3c
to
c1dc52d
Compare
andrewfullard
approved these changes
May 13, 2024
|
This can be merged if docs build locally |
|
*beep* *bop* Hi, human. The Click here to see your results. |
atharva-2001
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first start of carving a position for the new plasma