-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unreachable dmg indicator code #3217
base: master
Are you sure you want to change the base?
Remove unreachable dmg indicator code #3217
Conversation
Now that I think about it thats not very nice. The way I understand it the The 0.7 protocol includes this parameter and there should be a way to use it. Imo it can be done before 0.8 and older clients simply see no damage indicators if a server decides to send client id -1 with a custom angle. |
Run CI in merge queue
…_space_in_systemc Remove trailing space in system.c teeworlds#3220
…unused Mark unused NETMSG_SNAPSMALL for 0.8 removal teeworlds#3210
https://github.com/teeworlds/teeworlds/blob/a1911c8f7d8458fb4076ef8e7651e8ef5e91ab3e/datasrc/network.py#L253 NetEvent("Damage:Common", [ # Unused yet NetIntRange("m_ClientID", 0, 'MAX_CLIENTS-1'), NetIntAny("m_Angle"), NetIntRange("m_HealthAmount", 0, 9), NetIntRange("m_ArmorAmount", 0, 9), NetBool("m_Self"), ]), Snap items with a m_ClientID out of range will be dropped during snap item validation.
4cc1bbe
to
a418c36
Compare
Remove unreachable dmg indicator code teeworlds#3217
teeworlds/datasrc/network.py
Line 253 in a1911c8
Snap items with a m_ClientID out of range will be dropped during snap item validation.
Thanks to @TsFreddie the original author of this code for helping me figure this out c: