fix pod client creation; move streamLogs onto reconciler thread

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
tektoncd · Feb 21, 2024 · f9f94f4 · f9f94f4
1 parent 83dfded
commit f9f94f4
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/pkg/watcher/reconciler/dynamic/dynamic.go b/pkg/watcher/reconciler/dynamic/dynamic.go
@@ -337,22 +337,21 @@ func (r *Reconciler) sendLog(ctx context.Context, o results.Object) error {
 			zap.String("name", o.GetName()),
 		)
 
-		go func() {
-			err := r.streamLogs(ctx, o, labelKey, logName)
-			if err != nil {
-				logger.Errorw("Error streaming log",
-					zap.String("namespace", o.GetNamespace()),
-					zap.String("kind", o.GetObjectKind().GroupVersionKind().Kind),
-					zap.String("name", o.GetName()),
-					zap.Error(err),
-				)
-			}
-			logger.Debugw("Streaming log completed",
+		err = r.streamLogs(ctx, o, labelKey, logName)
+		if err != nil {
+			logger.Errorw("Error streaming log",
 				zap.String("namespace", o.GetNamespace()),
 				zap.String("kind", o.GetObjectKind().GroupVersionKind().Kind),
 				zap.String("name", o.GetName()),
+				zap.Error(err),
 			)
-		}()
+			return err
+		}
+		logger.Debugw("Streaming log completed",
+			zap.String("namespace", o.GetNamespace()),
+			zap.String("kind", o.GetObjectKind().GroupVersionKind().Kind),
+			zap.String("name", o.GetName()),
+		)
 	}
 
 	return nil