Enable storing of Run Events as Record #748
Conversation
tekton-robot
added
release-note
tekton-robot
added
the
kind/feature
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-results-build-tests |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
All Events related to taskrun are stored when we are done with Runs and in a single List. This can be controlled by flag passed to watcher "store-event". Put it to false disable storing of eventlist. Record Name of EventList is stored as `results.tekton.dev/eventlist` in TaskRun and PipelineRun.
|
/test pull-tekton-results-build-tests |
There was a problem hiding this comment.
/assign @sayan-biswas @avinal @enarha Please review this PR.
|
The following is the coverage report on the affected files.
|
|
I'll take a look over the next day or two @khrm - thanks |
There was a problem hiding this comment.
generally looks good to me @khrm
just one comment on the default enablement of the feature
| @@ -68,6 +68,7 @@ var ( | |||
| namespace = flag.String("namespace", corev1.NamespaceAll, "Should the Watcher only watch a single namespace, then this value needs to be set to the namespace name otherwise leave it empty.") | |||
| checkOwner = flag.Bool("check_owner", true, "If enabled, owner references will be checked while deleting objects") | |||
| updateLogTimeout = flag.Duration("update_log_timeout", 30*time.Second, "How log the Watcher waits for the UpdateLog operation for storing logs to complete before it aborts.") | |||
| storeEvent = flag.Bool("store_event", true, "If enabled, events related to runs will also be stored") | |||
There was a problem hiding this comment.
should be off by default
events are even more numerous than secrets and config map on a k8s cluster - we should not impact performance by default
There was a problem hiding this comment.
It should be false. It was enabled for testing. Will change it.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
All Events related to taskrun or PipelineRun are stored when we are done with Runs and in a single List.
This can be controlled by a flag passed to the watcher: "store-event". Setting it to false
disables the storing of Events.
The record Name of EventList is stored as
results.tekton.dev/eventlistin TaskRun and PipelineRun.Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes