Added support for TenableAD license APIs #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMcGrath
force-pushed
the
feature/tenable.ad-license
branch
from
1902086
to
29f2c82
Compare
tushar-balwani
force-pushed
the
feature/tenable.ad-license
branch
from
29f2c82
to
dc7240e
Compare
SteveMcGrath
requested changes
Jan 19, 2022
tenable/ad/license/api.py
Outdated
Comment on lines
34
to
52
| def create(self, | ||
| ad_license: str | ||
| ) -> Dict: | ||
| ''' | ||
| Create new license singleton | ||
|
|
||
| Args: | ||
| ad_license (str): | ||
| The AD license string object. | ||
|
|
||
| Return: | ||
| The license object | ||
|
|
||
| Example: | ||
| >>> tad.license.create( | ||
| ... ad_license='license' | ||
| ... ) | ||
| ''' | ||
| payload = self._schema.dump(self._schema.load({ | ||
| 'license': ad_license | ||
| })) |
There was a problem hiding this comment.
Suggested change
| def create(self, | |
| ad_license: str | |
| ) -> Dict: | |
| ''' | |
| Create new license singleton | |
| Args: | |
| ad_license (str): | |
| The AD license string object. | |
| Return: | |
| The license object | |
| Example: | |
| >>> tad.license.create( | |
| ... ad_license='license' | |
| ... ) | |
| ''' | |
| payload = self._schema.dump(self._schema.load({ | |
| 'license': ad_license | |
| })) | |
| def create(self, license: str) -> Dict: | |
| ''' | |
| Create new license singleton | |
| Args: | |
| license (str): | |
| The license string object. | |
| Return: | |
| The license object | |
| Example: | |
| >>> tad.license.create( | |
| ... license='license' | |
| ... ) | |
| ''' | |
| payload = self._schema.dump(self._schema.load({ | |
| 'license': license | |
| })) |
There was a problem hiding this comment.
implemented suggested changes
tests/ad/license/test_license_api.py
Outdated
| 'type': 'license type' | ||
| } | ||
| ) | ||
| resp = api.license.create(ad_license='license') |
There was a problem hiding this comment.
Suggested change
| resp = api.license.create(ad_license='license') | |
| resp = api.license.create(license='license') |
There was a problem hiding this comment.
implemented suggested changes
Comment on lines
27
to
29
| @pre_load | ||
| def convert(self, data, **kwargs): | ||
| return convert_keys_to_camel(data, special=['search_user_dn']) | ||
| return convert_keys_to_camel(data, special=[SEARCH_USER_DN]) |
There was a problem hiding this comment.
no longer necessary per #526
There was a problem hiding this comment.
removed pre_load method
tenable/ad/constants.py
Outdated
Comment on lines
1
to
8
| ''' | ||
| Constants | ||
| ''' | ||
|
|
||
| # field-names constants that are required to be converted to | ||
| # last word uppercase | ||
| SEARCH_USER_DN: str = 'search_user_dn' # ad-ldap-configuration | ||
| EXPIRATION_DATE_UTC: str = 'expiration_date_utc' # ad-license |
There was a problem hiding this comment.
no longer necessary per #526
There was a problem hiding this comment.
removed constants file
Added feature - TenableAD license APIs rebased to master and done requested changes
tushar-balwani
force-pushed
the
feature/tenable.ad-license
branch
from
dc7240e
to
545a76e
Compare
SteveMcGrath
approved these changes
May 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
Tenable.AD License APIsupdated docs to support license api details
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: