Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for TenableAD Application Settings APIs #511

Merged
merged 2 commits into from May 21, 2024

Conversation

tushar-balwani
Copy link
Contributor

Description

Added Tenable.AD Application Settings APIs

  • Get the application settings (get)
  • Update the application settings (update)

updated docs to support application settings api details

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added tests for application setting endpoints to test responses
  • Added schema tests for testing payload inputs and response dict validation

Test Configuration:

  • Python Version(s) Tested: 3.8.6
  • Tenable.sc version (if necessary):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tushar-balwani tushar-balwani requested review from SteveMcGrath and a team January 6, 2022 12:15
@tushar-balwani tushar-balwani force-pushed the feature/tenable.ad.application_settings branch 2 times, most recently from 47fbdfe to 4426a9a Compare January 10, 2022 08:40
tenable/ad/application_settings/api.py Outdated Show resolved Hide resolved
tenable/ad/constants.py Outdated Show resolved Hide resolved
Added feature - TenableAD Application Settings APIs

updated tests by removing obsolete fields

updated TenableAD base schema

update application settings schema and removed constants file
@SteveMcGrath SteveMcGrath requested a review from a team as a code owner May 21, 2024 19:18
Copy link

sonarcloud bot commented May 21, 2024

@SteveMcGrath SteveMcGrath merged commit 9ae5631 into master May 21, 2024
16 checks passed
@SteveMcGrath SteveMcGrath deleted the feature/tenable.ad.application_settings branch May 21, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants