Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for TenableAD attack type option APIs #516

Merged
merged 2 commits into from May 21, 2024
Merged

Added support for TenableAD attack type option APIs #516

merged 2 commits into from May 21, 2024

Conversation

tushar-balwani
Copy link
Contributor

Description

Added Tenable.AD Attack Type Option APIs

  • Get all the attack type options related to a profile and attack type. (get)
  • Create attack type options related to a profile and attack type. (create)

updated docs to support attack type option api details

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added tests for attack type option endpoints to test responses
  • Added schema tests for testing payload inputs and response dict validation

Test Configuration:

  • Python Version(s) Tested: 3.8.6
  • Tenable.sc version (if necessary):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tushar-balwani tushar-balwani requested review from SteveMcGrath and a team January 12, 2022 11:22
SteveMcGrath
SteveMcGrath requested changes Jan 19, 2022
View reviewed changes
tenable/ad/attack_type_options/schema.py Outdated
Comment on lines 36 to 38
@pre_load
def convert(self, data, **kwargs):
return convert_keys_to_camel(data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#526 Negates this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed pre_load method

@tushar-balwani
Added feature - TenableAD Attack Type Options APIs
2ffdefe 
updated staged param to bool

removed unused import

removed convert from schema
@tushar-balwani tushar-balwani force-pushed the feature/tenable.ad.attack_type_options branch from 865ec68 to 2ffdefe Compare January 20, 2022 07:33
@SteveMcGrath SteveMcGrath requested a review from a team as a code owner May 21, 2024 19:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SteveMcGrath SteveMcGrath merged commit 5014645 into master May 21, 2024
16 checks passed
@SteveMcGrath SteveMcGrath deleted the feature/tenable.ad.attack_type_options branch May 21, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMcGrath SteveMcGrath SteveMcGrath approved these changes

@tomeara tomeara Awaiting requested review from tomeara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tushar-balwani @SteveMcGrath