Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for TenableAD Deviance APIs #537

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tushar-balwani
Copy link
Contributor

Description

Added Tenable.AD Deviance APIs

  • Get all deviances for a directory. (list)
  • Get ad-object-deviance-history instance by id. (get_history_details)
  • Update ad-object-deviance-history instance. (update_history_details)
  • Get all deviances related to a single directory and checker. (list_by_directory_and_checker)
  • Get all deviances by checker. (list_by_checker)
  • Update instances matching a checkerId. (update_by_checker)
  • Search all deviances by profile by checker by AD object (search)
  • Update the deviances emitted on a specific AD object and for a specific checker. (update_on_ado_and_checker)

updated docs to support deviance api details

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added tests for deviance endpoints to test responses
  • Added schema tests for testing payload inputs and response dict validation

Test Configuration:

  • Python Version(s) Tested: 3.8.6
  • Tenable.sc version (if necessary):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tushar-balwani tushar-balwani requested review from tomeara and a team February 1, 2022 09:21
Copy link
Collaborator

@aseemsavio aseemsavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sync your changes with the master branch.

@SteveMcGrath SteveMcGrath requested a review from a team as a code owner May 21, 2024 20:03
@SteveMcGrath SteveMcGrath dismissed aseemsavio’s stale review May 21, 2024 20:04

No longer working on library

Copy link

sonarcloud bot commented May 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants