Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Tenable.io test-cases and cassettes #692

Closed
wants to merge 2 commits into from

Conversation

MitaliUpadhyay
Copy link
Contributor

@MitaliUpadhyay MitaliUpadhyay commented Apr 11, 2023

Description

As part of this PR, I have updated test-cases of Tenable.io and generated new cassettes for most of all Tenable.io test-cases.
Test-cases are updated fulfil below requirements:

  1. Some test-cases are getting failed with actual client-server call (i.e. --vcr-record=all). So I have fixed those test-cases.
  2. Updated flow of few test-cases to use dynamic id instead of static ids. So that in future it can be run with --vcr-record=all without any problem.
  3. Added some extra checks for parameters observed in response of actual API calls of test-cases.

Note:

Still 3 test-cases are getting failed with --vcr-record=all, as I am not sure the exact flow of these. So I have marked them as xfail/skip.

  • test_list_scanners_permissionerror.yaml
    
  • test_tags_create_filters_and_access_control_success
    
  • test_tags_edit_filters_and_access_control_success
    

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I have ran the test-cases --vcr-record=none, --vcr-record=once and --vcr-record=all. All are getting passed.

Test Configuration:

  • Python Version(s) Tested: 3.9

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MitaliUpadhyay MitaliUpadhyay marked this pull request as ready for review April 12, 2023 04:36
@MitaliUpadhyay MitaliUpadhyay requested a review from a team April 12, 2023 04:36
@MitaliUpadhyay MitaliUpadhyay marked this pull request as draft April 12, 2023 04:55
@SteveMcGrath SteveMcGrath deleted the bugfix/pyTenable_Tenable_io_test-cases branch May 15, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants