Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SC Files method as per #762 #771

Merged
merged 1 commit into from May 14, 2024
Merged

Updated SC Files method as per #762 #771

merged 1 commit into from May 14, 2024

Conversation

SteveMcGrath
Copy link
Contributor

Description

Addresses the 2G limitation that seems to occur with the file upload API. This converts the method from loading the entire file into memory to streaming the file to the remote API.

Fixes #762

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested by uploading the tarball to a test environment && checking memory usage.

Test Configuration:

  • Python Version(s) Tested: 3.9.9
  • Tenable.sc version (if necessary): 6.3.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SteveMcGrath SteveMcGrath requested a review from a team as a code owner May 10, 2024 20:15
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
93.3% Coverage on New Code (required ≥ 95%)

See analysis details on SonarCloud

@SteveMcGrath SteveMcGrath merged commit 08cce90 into master May 14, 2024
9 of 14 checks passed
@SteveMcGrath SteveMcGrath deleted the bugfix/762 branch May 14, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with plugin upload functionality
2 participants