Skip to content

Commit

Permalink
Replace sscanf by std::istringstream
Browse files Browse the repository at this point in the history
Using std::istringstream allows conversion of string to float
independent of the current locale setting.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
  • Loading branch information
stweil committed May 12, 2019
1 parent c76ceaf commit 5d92fbf
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions src/classify/clusttool.cpp
Expand Up @@ -142,17 +142,22 @@ uint16_t ReadSampleSize(TFile *fp) {
*/
PARAM_DESC *ReadParamDesc(TFile *fp, uint16_t N) {
PARAM_DESC *ParamDesc;
char linear_token[TOKENSIZE], essential_token[TOKENSIZE];

ParamDesc = static_cast<PARAM_DESC *>(Emalloc (N * sizeof (PARAM_DESC)));
for (int i = 0; i < N; i++) {
const int kMaxLineSize = TOKENSIZE * 4;
char line[kMaxLineSize];
ASSERT_HOST(fp->FGets(line, kMaxLineSize) != nullptr);
ASSERT_HOST(sscanf(line,
"%" QUOTED_TOKENSIZE "s %" QUOTED_TOKENSIZE "s %f %f",
linear_token, essential_token, &ParamDesc[i].Min,
&ParamDesc[i].Max) == 4);
std::istringstream stream(line);
// Use "C" locale (needed for float values Min, Max).
stream.imbue(std::locale::classic());
std::string linear_token;
stream >> linear_token;
std::string essential_token;
stream >> essential_token;
stream >> ParamDesc[i].Min;
stream >> ParamDesc[i].Max;
ASSERT_HOST(!stream.fail());
ParamDesc[i].Circular = (linear_token[0] == 'c');
ParamDesc[i].NonEssential = (essential_token[0] != 'e');
ParamDesc[i].Range = ParamDesc[i].Max - ParamDesc[i].Min;
Expand Down

0 comments on commit 5d92fbf

Please sign in to comment.