Added support for proxy, updated packages and more. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnysheoran
requested review from
mateusfreira,
goeverest,
dreich-nucleus and
testbetter
vnysheoran
commented
Sep 9, 2021
mateusfreira
previously approved these changes
Sep 9, 2021
dreich-nucleus
requested changes
Sep 9, 2021
|
Addressed Changes requested by @dreich-nucleus |
dreich-nucleus
requested changes
Oct 18, 2021
| @@ -18,6 +23,34 @@ if (apiPort.get('API_TESTS_PATH')) { | |||
| apiPort.currentFile = filePath; | |||
| const config = loadYamlFile(filePath); | |||
| describe(filePath, () => { | |||
| let tagsInTest = []; | |||
| if (tagsInTest) { | |||
There was a problem hiding this comment.
This is always true. Empty arrays are not "falsey". So, this block always executes. Just remove the if.
Unless you meant to check something that might be false - like the config.apiCalls.tag or tagsArray.length (remember tagArray will be truthy even when empty).
| } | ||
| if (tagsArray.length > 0) { | ||
| let tagMatched = false; | ||
| for (const tagInArgs of tagsArray) { |
There was a problem hiding this comment.
Use lodash and one of its many set operators here - intersection is probably the one you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added these two new flags in command-line arguments
Content-length set to Zero when the body is empty.