Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Return to lobby if preferences unavailable" #4308

Closed
wants to merge 6 commits into from

Commits on Jul 31, 2014

  1. "Do not play if preferences unavailable"

    Adds a new option to how the game handles a situation where a player doesn't qualify for any jobs they have set. Previously you could only have it set to play a random job (risky and potentially unfun) or play assistant (greytide).
    
    Players that use this but fail to qualify for anything they want get sent in as an observer in the same way they would if they had just hit observe. Because of how the game handles antag selection a player who is disqualified in this way is availible for antagonist roles that choose before job handling (malf/nuke ops/wizard), but not for ones that choose after (everything else). Going forward with a little work monkey/blob (the other two "the job doesn't really matter" modes) antags could be added to the other list if so desired.
    
    I feel that this would almost completely remove all the roundstart suicides/greytide by providing a "way out" for people who would otherwise get shunted into roles where they would have no desire to play the game and/or just be an asshole. It would also keep crew sizes down on hyper bloated servers.
    
    I know the freeze is still on, but I'm posting it now due to how it may synergize/antagonize with tgstation#4306 . Obviously neither should be merged until the freeze is over either way.
    Incoming5643 committed Jul 31, 2014
    Copy the full SHA
    df27cfd View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2014

  1. Changes the option from ghosting if no job found to returning to lobb…

    …y if no job found
    
    Changed the var from userandomjob to joblessrole to better show what it means now
    Changed savefile sanitation to make sure the new setting is actually considered a rational choice
    Removed Magic Numbers
    Incoming5643 committed Aug 14, 2014
    Copy the full SHA
    78d3410 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' of https://github.com/tgstation/-tg-station int…

    …o DoNotPlay
    
    Conflicts:
    	code/modules/mob/new_player/new_player.dm
    Incoming5643 committed Aug 14, 2014
    Copy the full SHA
    069133e View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2016

  1. Merge branch 'master' of https://github.com/tgstation/-tg-station int…

    …o DoNotPlay
    
    # Conflicts:
    #	code/game/jobs/job_controller.dm
    #	code/modules/client/preferences.dm
    #	code/modules/client/preferences_savefile.dm
    Incoming5643 committed Jul 18, 2016
    Copy the full SHA
    1bc098a View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    5c89940 View commit details
    Browse the repository at this point in the history
  3. Lets try one last time

    Incoming5643 committed Jul 18, 2016
    Copy the full SHA
    252c11b View commit details
    Browse the repository at this point in the history