Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

General maintenance for smoke machine #83158

Merged
merged 10 commits into from May 15, 2024

Conversation

SyncIt21
Copy link
Contributor

@SyncIt21 SyncIt21 commented May 9, 2024

About The Pull Request

1. Qol

  • Adds examines & screentips for screwdriver, crowbar, wrench acts & inserting reagents
  • Adds examines for viewing reagents present & efficiency of the smoke machine
  • Removes power cell from smoke machine required component parts. It's used nowhere in operation & is a waste of a good cell

2. Code Improvements

  • Replaced attackby() with item_interaction()
  • Begins & ends processing only when the player turns the machine on/off & not just when power is available
  • Removed unused vars like cooldown & user_amount
  • Correctly autodocs remaining vars
  • Improved UI code to use existing BeakerDisplay props

3. Fixes

  • You no longer hit the smoke machine when inserting reagents into it via beaker or other open containers
  • You can hit the smoke machine with tools like screwdriver, crowbar, wrench & open containers when in combat mode
  • No abstract & hologram item interactions with smoke machine

Changelog

馃啈
qol: adds examines & screentips for tool & container actions on the smoke machine
qol: smoke machine no longer requires a power cell for construction
code: autodocs & removes vars for some machine, Updated attack chain to latest standards for smoke machine
fix: You no longer hit the smoke machine with the beaker
fix: You can hit the smoke machine with tools & beakers when in combat mode
fix: no abstract & hologram item interactions allowed with smoke machine
/:cl:

@tgstation-server tgstation-server added Fix Rewrites a bug so it appears in different circumstances UI We make the game less playable, but with round edges Code Improvement Code is now easier to copy paste. Quality of Life Increasing esword damage is not a quality of life for traitors labels May 9, 2024
@github-actions github-actions bot requested a review from stylemistake May 9, 2024 08:39
Copy link
Contributor

@00-Steven 00-Steven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this didn't have reviews yet, so did a very brief lookover and some basic tests.
On a base level seems to be functional, I could toss in beaker contents or hook up plumbing and turn it on. Making the board, (de)constructing, (un)anchoring, and upgrading seemed to work fine.

Aside from that, found a nitpick with the screentips, and a bug with being able to turn it on while unanchoring.

Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com>
@SyncIt21 SyncIt21 marked this pull request as draft May 14, 2024 03:31
@SyncIt21 SyncIt21 marked this pull request as ready for review May 14, 2024 07:12
Copy link
Contributor

@00-Steven 00-Steven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again, can confirm I can no longer put it in a broken unanchored-but-on state, and haven't found any more egregious issues with it since.
If there's more they're not obvious to me. o7

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Code is now easier to copy paste. Fix Rewrites a bug so it appears in different circumstances Quality of Life Increasing esword damage is not a quality of life for traitors UI We make the game less playable, but with round edges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants