New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
General maintenance for smoke machine #83158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw this didn't have reviews yet, so did a very brief lookover and some basic tests.
On a base level seems to be functional, I could toss in beaker contents or hook up plumbing and turn it on. Making the board, (de)constructing, (un)anchoring, and upgrading seemed to work fine.
Aside from that, found a nitpick with the screentips, and a bug with being able to turn it on while unanchoring.
Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again, can confirm I can no longer put it in a broken unanchored-but-on state, and haven't found any more egregious issues with it since.
If there's more they're not obvious to me. o7
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
About The Pull Request
1. Qol
2. Code Improvements
attackby()
withitem_interaction()
cooldown
&user_amount
BeakerDisplay
props3. Fixes
Changelog
馃啈
qol: adds examines & screentips for tool & container actions on the smoke machine
qol: smoke machine no longer requires a power cell for construction
code: autodocs & removes vars for some machine, Updated attack chain to latest standards for smoke machine
fix: You no longer hit the smoke machine with the beaker
fix: You can hit the smoke machine with tools & beakers when in combat mode
fix: no abstract & hologram item interactions allowed with smoke machine
/:cl: