Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS2Properties uniqueness #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CSS2Properties uniqueness #30

wants to merge 1 commit into from

Conversation

putermancer
Copy link

All instances of CSS2Properties currently share an instance of a single object for this.styleIndex. This makes it so that if you set a style on divA, divB also reflects the change.

This patch addresses the issue by extending a new object with supportedStyles for each instance of CSS2Properties.

@putermancer
Copy link
Author

Bit me during some tests. I just noticed however that this is a duplicate pull request. Pull request #19 addresses this issue in the same manner, but also allows access ti styles set through innerHTML -- it may be worth looking at instead of this pull request.

#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@putermancer @thatcher