Skip to content

Add alliance details to team detail page #5937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devyntk
Copy link
Contributor

@devyntk devyntk commented May 15, 2024

This PR provides details about Alliance Selection and that Alliance's progression.

Motivation and Context

I often find myself switching back and forth between event pages and alliance pages to determine an team's alliance, and find that the data should just be presented inline.

How Has This Been Tested?

There seem to be no automated tests for the team renderer, so no automated tests were done. Manual tests were done with:

  • District teams
  • Regional teams
  • Teams that were listed as backups, both in the backup field as well as a fake third pick
  • Events that have specialized alliance names

Screenshots (if appropriate):

image
image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change API specifications or require data migrations)

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 95.37572% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.88%. Comparing base (24652da) to head (ec9860b).
Report is 210 commits behind head on py3.

Files Patch % Lines
src/backend/common/helpers/alliance_helper.py 91.76% 7 Missing ⚠️
src/backend/web/renderers/team_renderer.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              py3    #5937      +/-   ##
==========================================
- Coverage   93.10%   92.88%   -0.23%     
==========================================
  Files         658      659       +1     
  Lines       42145    42665     +520     
  Branches       60       60              
==========================================
+ Hits        39241    39631     +390     
- Misses       2896     3026     +130     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions bot added a commit that referenced this pull request Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

Screenshots

Homepage

Homepage

GameDay

GameDay

github-actions bot added a commit that referenced this pull request Jun 4, 2024
@devyntk devyntk requested a review from fangeugene June 4, 2024 02:34
Copy link
Member

@fangeugene fangeugene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. The new typing renaming and organization make a whole lot of sense. A few questions/comments

@devyntk devyntk force-pushed the feature/team-detail-alliance-details branch from ac4848a to ec9860b Compare June 5, 2024 23:20
github-actions bot added a commit that referenced this pull request Jun 5, 2024
github-actions bot added a commit that referenced this pull request Jun 5, 2024
@devyntk devyntk requested a review from fangeugene June 5, 2024 23:33
Copy link
Member

@fangeugene fangeugene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@fangeugene fangeugene merged commit 2c8975b into the-blue-alliance:py3 Jun 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants