Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match no-leading-zero floats, e.g. '.2', as a number #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benmathes
Copy link

@benmathes benmathes commented Nov 29, 2016

Related to issue #340

@@ -447,7 +447,7 @@ Backbone.Validation = (function(_){
digits: /^\d+$/,

// Matches any number (e.g. 100.000)
number: /^-?(?:\d+|\d{1,3}(?:,\d{3})+)(?:\.\d+)?$/,
number: /^-?(?:\d+|\d{1,3}(?:,\d{3})+)?(?:\.\d+)?$/,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the material change.

Copy link

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a team member so this doesn't count for much, but LGTM.

blikblum pushed a commit to blikblum/backbone.validation that referenced this pull request Apr 21, 2018
@blikblum
Copy link
Contributor

This is fixed in a fork i'm maintaining (tried contact this repository admins without luck): https://github.com/blikblum/backbone.validation

The updated package can be found at https://www.npmjs.com/package/backbone.validation

To use with node: npm install backbone.validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants