Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to v2 of the REST API #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

lfepp
Copy link

@lfepp lfepp commented Jul 13, 2016

PagerDuty has deprecated v1 of the REST API so I have migrated your code to v2. In addition, I made a few other changes to the code:

  1. Updated code to be within the RuboCop style guidelines
  2. Updated the code to handle users with multiple email and/or phone contact methods
  3. Updated the second command line argument to be a service over a schedule. I think this is more useful as it will list the currently on-call user for the service regardless of whether the escalation policy tied to the service has a schedule on level one or just has the user added as level one. If you disagree I'm happy to close the PR and submit another based upon a schedule ID argument.

I ran a few tests on my end but please feel free to run a few tests as well and plug this into IRC before merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant