fix for http://cruisecontrolrb.lighthouseapp.com/projects/9150/ticket…

…s/212-builder-failure-if-svn-log-fails-with-credentials-error
thewoolleyman · Nov 28, 2008 · 0a4694b · 0a4694b
1 parent e7fa1ec
commit 0a4694b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/source_control/abstract_adapter.rb b/lib/source_control/abstract_adapter.rb
@@ -69,6 +69,7 @@ def execute_with_error_log(command, error_log)
         ensure
           FileUtils.rm_f(error_log)
         end
+        raise BuilderError.new(error_message, "source_control_error") unless error_message.empty?
         return stdout_output
       end
     end

diff --git a/test/unit/source_control/abstract_adapter_test.rb b/test/unit/source_control/abstract_adapter_test.rb
@@ -0,0 +1,16 @@
+require File.dirname(__FILE__) + '/../../test_helper'
+require 'stringio'
+
+class SourceControl::AbstractAdapterTest < Test::Unit::TestCase
+
+  include FileSandbox
+
+  def test_execute_with_error_log__handles_exceptions
+    @adapter = SourceControl::AbstractAdapter.new
+    in_total_sandbox do
+      assert_raise(BuilderError) do
+              @adapter.execute_with_error_log("xaswedf", @stderr)
+            end
+    end
+  end
+end