fix: history entry must have a PieceType, and therefore does not need to be an Option<PieceType>, but rather a PieceType
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to be an `Option<PieceType>`, but rather a `PieceType`
|
LGTM, you can rebase from main to resolve the conflicts in your IDE and then push again |
|
ping @JeromeSchmied just need to fix the conflict for a merge when you have time |
yup, I know, but I find this rebasing quite tricky, so it'll take some more time |
|
sure thing no problem @JeromeSchmied @ me when you are done mate ! |
|
Hello @JeromeSchmied checkout pr #65 @nicholasmello did another refactor of the move history and added a proper struct for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds refactor the History to create a new type
pub type HistRec = (PieceType, String);