Be clear about supported Rails and Ruby versions #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Ruby 2.7 and older] is end of life. [Rails 6.0 and older] is end of life. Rails 6 [requires] Ruby >= 2.5, Rails 7 requires Ruby >= 2.7. [Ruby 2.7 and older]: https://www.ruby-lang.org/en/downloads/branches/ [Rails 6.0 and older]: https://guides.rubyonrails.org/maintenance_policy.html [requires]: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#ruby-versions --- Don't require debug. This isn't needed for tests. But moreover, it causes an error on Ruby 3.0. It opens with: ``ruby if $SAFE > 0 STDERR.print "-r debug.rb is not available in safe mode\n" exit 1 end ``` But `$SAFE` is not set, so we get `nil > 0`, and an error. ``` % ruby -rdebug -e 'puts "OK"' /home/mike/.rubies/ruby-3.0.6/lib/ruby/3.0.0/debug.rb:9:in `<top (required)>': undefined method `>' for nil:NilClass (NoMethodError) from <internal:/home/mike/.rubies/ruby-3.0.6/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require' from <internal:/home/mike/.rubies/ruby-3.0.6/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require' ``` This is not an issue on Ruby 3.1. --- Ruby 3.1 + Rails 7.1 leads to an issue around the `error_highlight` library. Rather than debug that, we can skip that combination and hope for the best.
mike-burns
force-pushed
the
ruby-rails-version
branch
from
dec24ca
to
499635f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.7 and older is end of life.
Rails 6.0 and older is end of life.
Rails 6 requires Ruby >= 2.5, Rails 7 requires Ruby >= 2.7.
We also want to know about Rails main.