Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Patch to change aws/s3 to qoobaa/s3 to fix european bucket support #177

Closed
rob-at-thewebfellas opened this issue Mar 30, 2010 · 8 comments
Closed

Patch to change aws/s3 to qoobaa/s3 to fix european bucket support #177

rob-at-thewebfellas opened this issue Mar 30, 2010 · 8 comments

Comments

@rob-at-thewebfellas
Copy link
Contributor

Patch is here

It includes the following:

  • fix for test/unit problem if > 2.0 is installed
  • replacement of aws/s3 with qoobaa/s3 to provide support for european s3 buckets
  • fix for upfile tests

There is currently one failing test due to the lack of support for custom headers in the qoobaa/s3. I'm looking at a patch for this, but in the meantime give this patch a go and see how it goes.
@masterkain
Copy link

Hello,
interesting, I still have to try it, I forked the gist and fixed a probable typo on line 223.

Thanks

@rob-at-thewebfellas
Copy link
Contributor Author

Agreed on the typo: looks like paperclip had no tests for this before, so I've updated the patch to fix the typo and add a test. I've also changed the failing test to be pending until the s3 gem catches up.

@yholkamp
Copy link

Definitely a +1 from me as well!

@antonysastre
Copy link

+1 +1!!

@docgecko
Copy link

check this for a great instruction
http://thewebfellas.com/blog/2010/1/31/paperclip-vs-amazon-s3-european-buckets

@rob-at-thewebfellas
Copy link
Contributor Author

There's also a patched version of the storage module in my fork of the s3 gem:
http://github.com/thewebfellas/s3/blob/master/extra/s3_paperclip.rb

@jippi
Copy link

jippi commented Jul 22, 2010

What's the status of this patch?

@sikachu
Copy link
Contributor

sikachu commented Jun 23, 2011

I don't think we're going to move to another library. Please test and see if newer version of Paperclip has solved your issue.

@sikachu sikachu closed this as completed Jun 23, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@antonysastre @sikachu @masterkain @jippi @rob-at-thewebfellas @docgecko @yholkamp