Drop offsets when tokenizing with RegularParser #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderer
force-pushed
the
memory-usage-optimization
branch
2 times, most recently
from
5840350
to
4e3a622
Compare
thunderer
force-pushed
the
memory-usage-optimization
branch
from
4e3a622
to
65f14e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing using my sample string that was causing memory issues for me memory usage was reduced by 46% using refactor.
Super simple test, showing peak usage after processing (
aka. memory_get_peak_usage()) minus peak prior to processing.Also referenced in #110
Note on changes. Reversed order of cases in switch as when for example
markeris matched any subsequent captures (ex,separator) won't be present in matches array.