Change status code from 400 to 409 in docs_src /app_testing/ #11263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I consistently changed the status code in docs_src/app_testing/ from 400 to 409. Previously, it was inconsistently set to 400 in some places and 409 in others.
I believe that 409 is more appropriate than 400 for cases where the item already exists, as it indicates a resource conflict.
before
after
While working on a project using FastAPI and referring to the Documentation for writing test code, I encountered confusion due to the inconsistent status codes in the testing tutorial at https://fastapi.tiangolo.com/tutorial/testing/.
main.py
test_main.py
The documentation for Python 3.10+, Python 3.9+, and Python 3.8+ lists a status code of 400, whereas for Python 3.10+ non-Annotated and Python 3.8+ non-Annotated, it lists a status code of 409. However, in test_main.py, the status code is 409.