Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update routing.py to handle circular references #11425

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update routing.py to handle circular references #11425

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8a0a360
Update routing.py
JavierSanchezCastro Apr 11, 2024
e0771b7
Update routing.py
JavierSanchezCastro Apr 11, 2024
48e64dc
Merge branch 'tiangolo:master' into master
JavierSanchezCastro Apr 29, 2024
d4df0c3
Update routing.py
JavierSanchezCastro May 10, 2024
073828f
Merge branch 'tiangolo:master' into master
JavierSanchezCastro May 10, 2024
fce1dd7
[ADD] test
JavierSanchezCastro May 10, 2024
adab5ee
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] May 10, 2024
467cdb1
Merge branch 'tiangolo:master' into master
JavierSanchezCastro May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions fastapi/routing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,6 +1204,7 @@ def read_users():
app.include_router(internal_router)
```
"""
assert id(self) != id(router), "Router cannot be the same as parent"
JavierSanchezCastro marked this conversation as resolved.
Show resolved Hide resolved
if prefix:
assert prefix.startswith("/"), "A path prefix must start with '/'"
assert not prefix.endswith(
Expand Down