Properly calibrate the input device #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tester to test different possible sequences of clicks Signed-off-by: Blaž Tomažič <blaz.tomazic@gmail.com>
Update generic and evdev calibrators to calibrate the input depending on the sequence of the clicks and independent of the orientation of the screen. Signed-off-by: Blaž Tomažič <blaz.tomazic@gmail.com>
blaztinn
changed the title
|
Tested-by: Christian Gmeiner christian.gmeiner@gmail.com |
|
We use with success this pull request in our own debian package @ivsgroup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current calibration didn't properly calibrate the input device if the display screen was rotated or if one of the axis was mirrored by the HW. Maybe it didn't work in other cases too, but this are the ones I know of.
This patch fixes this problems by properly calibrating the input device on any possible click sequence, previous calibration and axis inversion (min-max switched).
First commit updates tester to test for all the possible sequences (before there was a missing click sequence where the y coordinate is changed first!)
The second commit updates the generic and evdev calibrations to properly calibrate the screen and pass the tests.
I've successfully tested this changes on two touchscreens (IR and SAW) which have different axis ranges and inversions.