-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization of xinput_calibrator #69
Open
zboszor
wants to merge
17
commits into
tias:master
Choose a base branch
from
zboszor:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui/gui_common.cpp: In function ‘void get_display_texts(std::__cxx11::list<std::__cxx11::basic_string<char> >*, Calibrator*)’: gui/gui_common.cpp:48:5: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation] else ^~~~ gui/gui_common.cpp:50:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘else’ texts->push_back(str); ^~~~~
and XTextWidth16 / XDrawString16 in the X11 GUI. The requested font name is "-misc-fixed-*-*-*--*-*-100-100-*-*-iso10646-1".
Mark strings for translation in src/gui/gui_common.cpp.
are enough to handle UTF-8 translations correctly. LC_ALL is overkill as it changes printf() formatting for numeric data, which is used in printing the calibration data and setting the X Atoms for calibration.
This reverts commit f20fc7f.
strings for the GUI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to use localized messages on the screen.
Added Hungarian translation as an example.
It needs the "font-misc-misc" ISO10646-1 (UTF-8) encoded X11 font family, otherwise some local characters would be missing.