Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): update cmake, checkstyle #13966

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

chore(android): update cmake, checkstyle #13966

wants to merge 6 commits into from

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jan 18, 2024

Note:

  • all Java file changes are just automatic linting in Android Studio! While updating checkstyle from 8 to 10 some rules changed so I had to manually open each file and run Android Studio lint (ctrl + shift + alt + L).

Tests:

  • SDK builds fine
  • java module builds fine
  • kotlin module builds fine
  • app with existing modules builds find and works

Tested on Fedora Linux

@m1ga
Copy link
Contributor Author

m1ga commented Jan 18, 2024

Interesting. The build script returns:

[CXX1300] CMake '3.27.7' was not found in SDK, PATH, or by cmake.dir property.
[CXX1301] - CMake '3.28.1' found in PATH did not satisfy requested version.
[CXX1301] - CMake '3.10.2' found in SDK did not satisfy requested version.
[CXX1301] - CMake '3.18.1' found in SDK did not satisfy requested version.
[CXX1301] - CMake '3.22.1' found in SDK did not satisfy requested version.

[CXX1300] CMake '3.27.7' was not found in SDK, PATH, or by cmake.dir property.
[CXX1301] - CMake '3.28.1' found in PATH did not satisfy requested version.
[CXX1301] - CMake '3.10.2' found in SDK did not satisfy requested version.
[CXX1301] - CMake '3.18.1' found in SDK did not satisfy requested version.
[CXX1301] - CMake '3.22.1' found in SDK did not satisfy requested version.

I'll check that

edit: going back to 3.22.1 as that is available here too.

@m1ga m1ga changed the title chore(android): update cmake chore(android): update cmake, checkstyle Feb 12, 2024
This was referenced Feb 13, 2024
@cb1kenobi
Copy link
Contributor

Is this PR ready for review? Is there any specific steps to test?

@m1ga
Copy link
Contributor Author

m1ga commented Feb 17, 2024

yes, you can review/test it. The tests I did are the one in the first post: build sdk, build a module (java and kotlin), build an app, build an app with 12.2.1 modules.

If you build with this PR it should download cmake and checkstyle during the first build if they are not installed already. Then you shouldn't see any lint error during the build (that's why there are the java file changes). checkstyle will run during the build process and throw an error if the java files aren't in the correct style.

So to summarize: if you can build the SDK and modules + app: everything works fine after this PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants