Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tidiers for car::durbinWatsonTest objects #341

Merged
merged 5 commits into from Jun 9, 2018

Conversation

mkuehn10
Copy link
Contributor

@mkuehn10 mkuehn10 commented Jun 9, 2018

Trying to resolve #266

@alexpghayes
Copy link
Collaborator

You need to add car to Suggests in DESCRIPTION. Probably the best way to do this is with the usethis package: usethis::use_package("car", type = "Suggests") I believe. Then you'll want to use library(car) in the test file, or refer to the test function with a car:: prefix.

Does that help?

@alexpghayes
Copy link
Collaborator

Also I think it would be best to just implement a glance method, and no tidy. tidy is meant to be used on model components, but here we can only really summarize the whole model, so glance is the way to go.

@mkuehn10
Copy link
Contributor Author

mkuehn10 commented Jun 9, 2018

I noticed that the htest tidiers make the tidy and glance the same, so that's what I did for this one as well.

@alexpghayes
Copy link
Collaborator

Okay, that's fine then!

@alexpghayes alexpghayes merged commit c5e574f into tidymodels:master Jun 9, 2018
@mkuehn10
Copy link
Contributor Author

@karldw I think this resolves #266

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glance method for object of class DurbinWatsonTest
2 participants