New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tidiers for drc #574
Conversation
Thanks! I'll take a look at the augment method in a couple days! |
Problem, is that I had this code hanging around for >2 years. In the meantime broom grew and developed much further and I could not pick up the latest changes (though I read the documentation). |
@alexpghayes I fixed also the augment.drc() part - so no need for you to check. |
@alexpghayes If you have any suggestions/comments we could have also a chat in person at rstudio::conf (I am participating in the ML workshop). |
Getting some
errors, when testing. Although I do inline definition of columns
Any idea? |
Yes, let's chat in person! Just flag me down!
…On Wed, Jan 16, 2019 at 10:36 AM Eduard Szöcs ***@***.***> wrote:
Getting some
Arguments conf.int, conf.level to augment.drc must be listed in the
argument glossary.
errors, when testing. Although I do inline definition of columns
return_augment(".conf.low" = "Lower Confidence Interval",
[snip]
Any idea?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#574 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AOYTa8Pe14ChmOvUqUbNX77aVMxdcMEpks5vD1T0gaJpZM4Zynzv>
.
|
I'm sorry that I haven't look at this yet. I'll try to give this a thorough review over the weekend! |
I'm sorry for the delay on this! I'm going to go ahead and merge and poke through the code as I have time! |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Added tidiers for drc, which provides a big variety of dose-response-models.
Example:
I really had to fight with the tests for
augment()
, but I could not get them pass :(. Code is in here, but uncommented. If someone more experienced with broom might want to look into it.Failing tests are unrelated to this PR.