Change names of interval columns in augment() for clarity

[bwiernik]

Closes #921

• Changes .conf.low to .lower and .conf.high to .upper consistently for augment() output.
• Updates agument.rma() to consistently return one set of intervals.

[simonpcouch]

Thanks for making this happen!

I'm feeling positive about how this came together with respect to the first bullet.

I dropped a comment in about the second.

Could you ensure that changes have been made only to relevant documentation? Quite a few .Rd files with changes only in the help-files they link out to.

[bwiernik]

I've reverted the documentation entirely.

When I try to run devtools::document(), it doesn't seem to be producing the correct output (e.g., the Value table disappears entirely for agument.rma; and the Value table for augment.lm is missing the interval arguments). I think this has to do with the return_arguments() helper function, but I'm not sure what I need to do to fix it.

(The other files being modified was that some of the .Rd files seem out of sync with the roxygen templates.)

[simonpcouch]

That's fine.👍

The other modified files are a result of differences in package versions. Recent switch in how documentation gets linked from place to place that can be a pain in package dev.

[simonpcouch]

Great, much appreciated!

There are some modeltests errors (along the lines of Output column names not in the column glossary) and some code/doc mismatch failures (since I had you roll back docs) that are fine to ignore from your end. Looks like there's still one failure in the examples that just requires some column renaming in a ggplot call--could you make that happen?

I'm feeling positive about where this is at. Looping you in, @alexpghayes.

[bwiernik]

I’ll take a look tomorrow afternoon.

[bwiernik]

@simonpcouch The example errors are just because the documentation Rd is out of sync with the roxygen. In the roxygen, all of the ggplot calls refer to .lower and .upper, but because I didn't run document() because of the modeltestr mismatch, they are erroring.

[bwiernik]

@simonpcouch Did you want me to change anything regarding those errors or is this fine for now?

[simonpcouch]

Oh, gotcha! No worries on the errors, then. Thanks for checking in.

[simonpcouch]

Thanks for your patience!

Alex and I finally had a chance to talk on this, and we're game. Thanks for the contribution. Will go ahead and fix conflicts and then merge.

[bwiernik]

Thanks so much! Glad it got merged!

[github-actions]

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.