-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spatial model support for tidy, glance, and augment #97
Comments
Hey @DHLocke. Apologies for the long delay in getting back to you. These seem like great additions. I don't use spatial models much day to day, so I'm not particularly aware of what kind of information is useful. Do you have any feedback about output what you'd want to see from |
Now its my turn to apologize for a slow response.
For *lagsarlm*, AIC, rho and its significance test would be nice to have in
*glance*.
For, *errorsarlm*, AIC, lambda its significance test would be nice to have
in *glance*.
It would be great if tidy worked on both *lagsarlm* and *errorsarlm*.
gwr already does a version of augment naturally.
Best, Dexter
…On Fri, Jul 13, 2018 at 3:44 PM alex hayes ***@***.***> wrote:
Hey @DHLocke <https://github.com/DHLocke>. Apologies for the long delay
in getting back to you. These seem like great additions. I don't use
spatial models much day to day, so I'm not particularly aware of what kind
of information is useful. Do you have any feedback about output what you'd
want to see from tidy, glance and augment methods for lagsarlm, errorsarlm
and gwr models?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#97 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/APW6BpvvugZt6JXb8p42eDfYCIVNPk3cks5uGSLfgaJpZM4GsaNq>
.
|
cough @angela-li cough |
Hi guys, I have written basenline for spatial model, the main function are finished and now need pullish up. I now support lagsarlm and errorsarlm, please see here #841 I also provided examples |
Closing this in favor of #847.🙂 |
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Broom is fantastic, really great work! Thanks so much.
It would be great of broom's tidy(), glance() and augment() worked for spatial models. The three I have in mind are the spatial lag model created with lagsarlm(), and the spatial error model created with errorsarlm() in the spdep package. Also, gwr() models created with the spgwr package would a nice addition to broom's functionality. Although gwr() creates a new set of SpatialPolygonsDataFrame or a SpatialPointsDataFrame which is really similar to what augment() would do.
Although I've read a bunch of posts on github, this is my first github request. So please let me know if this isn't the best way to make a request, or if my etiquette stinks.
Thanks again for a great package, its so useful!
The text was updated successfully, but these errors were encountered: