Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spatial model support for tidy, glance, and augment #97

Closed
DHLocke opened this issue Dec 1, 2015 · 6 comments
Closed

spatial model support for tidy, glance, and augment #97

DHLocke opened this issue Dec 1, 2015 · 6 comments

Comments

@DHLocke
Copy link

DHLocke commented Dec 1, 2015

Broom is fantastic, really great work! Thanks so much.

It would be great of broom's tidy(), glance() and augment() worked for spatial models. The three I have in mind are the spatial lag model created with lagsarlm(), and the spatial error model created with errorsarlm() in the spdep package. Also, gwr() models created with the spgwr package would a nice addition to broom's functionality. Although gwr() creates a new set of SpatialPolygonsDataFrame or a SpatialPointsDataFrame which is really similar to what augment() would do.

Although I've read a bunch of posts on github, this is my first github request. So please let me know if this isn't the best way to make a request, or if my etiquette stinks.

Thanks again for a great package, its so useful!

@alexpghayes
Copy link
Collaborator

Hey @DHLocke. Apologies for the long delay in getting back to you. These seem like great additions. I don't use spatial models much day to day, so I'm not particularly aware of what kind of information is useful. Do you have any feedback about output what you'd want to see from tidy, glance and augment methods for lagsarlm, errorsarlm and gwr models?

@DHLocke
Copy link
Author

DHLocke commented Oct 14, 2018 via email

@alexpghayes
Copy link
Collaborator

cough @angela-li cough

@petrhrobar
Copy link
Contributor

Hi guys, I have written basenline for spatial model, the main function are finished and now need pullish up. I now support lagsarlm and errorsarlm, please see here #841

I also provided examples

@simonpcouch
Copy link
Collaborator

Closing this in favor of #847.🙂

@github-actions
Copy link

github-actions bot commented Mar 8, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants