Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard error to tidy_optim #530

Merged
merged 3 commits into from Nov 24, 2018
Merged

Conversation

billdenney
Copy link
Contributor

Fix #529

@alexpghayes
Copy link
Collaborator

I'm a fan. Can you a quick test and update the documentation?

@billdenney
Copy link
Contributor Author

Documentation: No problem.

I'm not familiar with the way that testing is done for broom (I looked at it, and it isn't similar to other testthat-based testing that I've done before). Can you give me a pointer to how I would do it?

@alexpghayes
Copy link
Collaborator

No need to do anything to base tests, those are already there. I would just add a test to https://github.com/tidymodels/broom/blob/master/tests/testthat/test-list-optim.R#L19 that makes sure the std.error column is present when applicable, and isn't when it shouldn't be. This might surprising to users, so documenting it carefully will be important!

Does that help?

@billdenney
Copy link
Contributor Author

I think that what I just pushed resolves those requests. Thanks for the guidance.

@alexpghayes alexpghayes merged commit c5d85b4 into tidymodels:master Nov 24, 2018
@alexpghayes
Copy link
Collaborator

Thanks!

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Standard Error for optim(), if Hessian is available
2 participants